fix: use safe_truncate to truncate charactor (#3263)#3264
Merged
DOsinga merged 6 commits intoblock:mainfrom Jul 15, 2025
Merged
fix: use safe_truncate to truncate charactor (#3263)#3264DOsinga merged 6 commits intoblock:mainfrom
DOsinga merged 6 commits intoblock:mainfrom
Conversation
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
toyamagu-2021
changed the title
toyamagu-2021
changed the title
toyamagu-2021
changed the title
Contributor
Author
DOsinga
approved these changes
Jul 8, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
this is great and thanks for jumping on this. if we want to completely fix this, we should also replace the text.len() instances with text.chars().count() or where possible replace
if text.len() > count {
safe_truncate(text)
} else {
text
}
with just safe_truncate(text)
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
Contributor
Author
|
@DOsinga |
Collaborator
|
this is great, thank you. do you have any ideas on what we could do to avoid us breaking this again :) ? |
Contributor
Author
|
@DOsinga And you can enable it using this command: However, this currently generates a large number of errors, including false positives, making it difficult to fix immediately. If you'd like, I can create an issue for it and address it in a separate pull request. |
Contributor
Author
|
CI is falling 🤔 |
zanesq
added a commit
that referenced
this pull request
Jul 15, 2025
* 'main' of github.com:block/goose: fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264) fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) feat: Add AZURE_OPENAI_API_KEY as a visible config parameter (#3265) feat: stream LLM responses (#2677) # Conflicts: # crates/goose/src/session/storage.rs # ui/desktop/src/components/ChatView.tsx # ui/desktop/src/components/settings/extensions/subcomponents/ExtensionList.tsx
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 16, 2025
* main: (54 commits) UI update with sidebar and settings tabs (#3288) docs: add CLIStreamExtensionInstructions component (#3443) chore(release): release version 1.0.36 (#3436) [goose-llm] fix image content bug, add optional request_id field (#3439) fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264) fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) ...
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 16, 2025
* main: UI update with sidebar and settings tabs (#3288) docs: add CLIStreamExtensionInstructions component (#3443) chore(release): release version 1.0.36 (#3436) [goose-llm] fix image content bug, add optional request_id field (#3439) fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264)
1 task
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com> Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com> Signed-off-by: Kyle Santiago <kyle@privkey.io>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com> Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: toyamagu2021@gmail.com toyamagu2021@gmail.com
Closes #3263
Same as #2819